Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[The Magic Highlighter] Remove cmdf from querystring #33

Open
1 task done
ironprogrammer opened this issue Apr 26, 2023 · 2 comments
Open
1 task done

[The Magic Highlighter] Remove cmdf from querystring #33

ironprogrammer opened this issue Apr 26, 2023 · 2 comments
Labels
enhancement request Feedback about enhancements to EXISTING product features up next These issues are next up in our priority queue

Comments

@ironprogrammer
Copy link

Product

The Magic Highlighter

Subject

Remove cmdf from querystring

Feedback

Currently when navigating to a search result, the target page URL is appended with ?cmdf=what+you+searched+for.

This requires some sanitation when copying that page's URL to be used elsewhere, and also reveals to the target site that the user has The Magic Highlighter enabled. Ideally, the URL would remain "clean", and not give away this private information.

What do you think?

Context

No response

Code of Conduct

  • I have read and agree to the Herd Works Product Feedback Issue Tracker project's Code of Conduct
@ironprogrammer ironprogrammer added the enhancement request Feedback about enhancements to EXISTING product features label Apr 26, 2023
@ironprogrammer ironprogrammer changed the title [<product>] <subject> [The Magic Highlighter] Remove cmdf from querystring Apr 26, 2023
@calebhailey
Copy link
Member

Now that the 0.7.0 release is done, I think I have an idea on how to address this, and I might work on it this month since it's starting to become a somewhat frequent request. 😊

@calebhailey calebhailey added the up next These issues are next up in our priority queue label May 11, 2023
@MariusVolkhart
Copy link

In iOS 17, if “Advanced Tracking and Fingerprint Protection” is on, the URL is sanitized and the extension stops working.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement request Feedback about enhancements to EXISTING product features up next These issues are next up in our priority queue
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@calebhailey @ironprogrammer @MariusVolkhart