-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consider adding a warning when PORT environment variable is missing at runtime #938
Comments
thephw
changed the title
Consider adding a warning when PORT environment variable is missing
Consider adding a warning when PORT environment variable is missing at runtime
Dec 16, 2019
Some historical context from the CNCF working group minutes:
|
@schneems You have any thoughts/feelings about this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Description
heroku-buildpack-ruby
require that the runtime specify aPORT
environment variable. Although consistent across buildpacks -- a recurring issue is building a rack image and forgetting to specify the port at runtime. For many buildpacks, the error is self evident.When building a rack application with the ruby buildpack, the error is a little more cryptic:
Suggestion
We could clarify the error message for all application without affecting compliance and integration with other language buildpacks.
Alternate Considerations
Code in question
heroku-buildpack-ruby/lib/language_pack/rack.rb
Line 32 in 22b24b6
Reference
buildpacks/samples#46
The text was updated successfully, but these errors were encountered: