Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make bundle clean have the same context as bundle install #347

Merged
merged 2 commits into from
Feb 25, 2015
Merged

Conversation

hone
Copy link
Member

@hone hone commented Feb 21, 2015

If a user has a crazy Gemfile where it executes code based on the environment, bundle clean might fail while bundle install works because the context is different. Let's pass the user env to bundle clean as well.

@schneems
Copy link
Contributor

👍

hone added a commit that referenced this pull request Feb 25, 2015
Make `bundle clean` have the same context as `bundle install`
@hone hone merged commit b2a953d into master Feb 25, 2015
@hone hone deleted the bundle_clean branch February 25, 2015 19:06
schneems added a commit that referenced this pull request Feb 27, 2015
outoftime pushed a commit to Genius/heroku-buildpack-ruby that referenced this pull request Mar 10, 2015
 into upstream_update

* 'master' of https:/heroku/heroku-buildpack-ruby: (51 commits)
  bump to v134
  v134 changelog
  Use more generic flag for sensible default detect
  Enable Rails 5 to work on Heroku
  changelog for heroku/heroku-buildpack-ruby#347
  Allow opting in to default WEB_CONCURRENCY
  pass user env to bundle clean, since it should run in the same env as bundle install
  use same bundler bin for every bundler command
  control all of our test repos
  don't vendor in JVM on cedar-14 as it's now available on the stack.
  changelog for 133
  bump to v133
  bundler 1.7
  Fail fast if ENV["STACK"] is missing
  bump to v132
  update changelog [ci skip]
  special case for patchlevel rubies. fixes jruby 9.0.0.0.pre1
  Set PX ram limits to correct value: https://devcenter.heroku.com/articles/dyno-size#available-dyno-sizes
  wait on autoscaling
  Scale back JRuby heap size on PX dynos to give room for native memory allocation
  ...
cbartlett added a commit to cbartlett/heroku-buildpack-ruby-tpope that referenced this pull request Mar 18, 2015
* heroku/master: (42 commits)
  bump to v134
  v134 changelog
  Use more generic flag for sensible default detect
  Enable Rails 5 to work on Heroku
  changelog for heroku/heroku-buildpack-ruby#347
  Allow opting in to default WEB_CONCURRENCY
  pass user env to bundle clean, since it should run in the same env as bundle install
  use same bundler bin for every bundler command
  control all of our test repos
  don't vendor in JVM on cedar-14 as it's now available on the stack.
  changelog for 133
  bump to v133
  bundler 1.7
  Fail fast if ENV["STACK"] is missing
  bump to v132
  update changelog [ci skip]
  special case for patchlevel rubies. fixes jruby 9.0.0.0.pre1
  Set PX ram limits to correct value: https://devcenter.heroku.com/articles/dyno-size#available-dyno-sizes
  wait on autoscaling
  Scale back JRuby heap size on PX dynos to give room for native memory allocation
  ...
aemengo pushed a commit to cloudfoundry/ruby-buildpack that referenced this pull request Mar 31, 2015
sibsfinx pushed a commit to sibsfinx/heroku-buildpack-ruby that referenced this pull request Apr 14, 2015
lcfg pushed a commit to lcfg/heroku-buildpack-jekyll that referenced this pull request Jun 22, 2015
lyoshenka added a commit to lyoshenka/heroku-buildpack-ruby-jekyll that referenced this pull request Aug 3, 2015
https:/codykrieger/heroku-buildpack-jekyll

* cody/master: (239 commits)
  bump to v134
  v134 changelog
  Use more generic flag for sensible default detect
  Enable Rails 5 to work on Heroku
  changelog for heroku/heroku-buildpack-ruby#347
  Allow opting in to default WEB_CONCURRENCY
  pass user env to bundle clean, since it should run in the same env as bundle install
  use same bundler bin for every bundler command
  control all of our test repos
  don't vendor in JVM on cedar-14 as it's now available on the stack.
  changelog for 133
  bump to v133
  bundler 1.7
  Fail fast if ENV["STACK"] is missing
  bump to v132
  update changelog [ci skip]
  special case for patchlevel rubies. fixes jruby 9.0.0.0.pre1
  Set PX ram limits to correct value: https://devcenter.heroku.com/articles/dyno-size#available-dyno-sizes
  wait on autoscaling
  Scale back JRuby heap size on PX dynos to give room for native memory allocation
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants