Colorize buildpack failures #788
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
schneems
force-pushed
the
schneems/red-failure
branch
12 times, most recently
from
891a6e5
to
3e5669e
Compare
sigmavirus24
approved these changes
Jul 3, 2018
lib/language_pack/base.rb
Outdated
| @@ -91,6 +91,7 @@ def compile | |||
| topic "DEPRECATIONS:" | |||
| puts @deprecations.join("\n") | |||
| end | |||
| Kernel.puts "\e[0m" | |||
There was a problem hiding this comment.
Do we want a comment to indicate this is "default"?
| e.message.split("\n").each do |line| | ||
| Kernel.puts " ! #{line.strip}" | ||
| end | ||
| Kernel.puts " !\e[0m" |
dzuelke
approved these changes
Jul 3, 2018
|
Worth mentioning that I tested this on windows 8 and it works |
schneems
force-pushed
the
schneems/red-failure
branch
from
a7029b1
to
d01b6bc
Compare
schneems
force-pushed
the
schneems/red-failure
branch
from
d01b6bc
to
c81a242
Compare
|
Changed to make warnings not so overbearing |
|
@dmathieu is there a reason you deleted the branch? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Example output for Errors:
Example output for Warnings: