[close #800] Don't add a default "worker" process if they don't have that task #810
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
schneems
force-pushed
the
schneems/worker-default-process-type
branch
from
b38de22
to
41f3320
Compare
|
Needs #809 merged |
schneems
force-pushed
the
schneems/worker-default-process-type
branch
from
41f3320
to
0ac884f
Compare
…that task This PR first detects if `jobs:work` exist before adding it as a default task. Similar to #806 but it uses the existing RakeRunner object and also adds testing. Special thanks to @JacobEvelyn for the original PR and the motivation.
schneems
force-pushed
the
schneems/worker-default-process-type
branch
from
0ac884f
to
76ce839
Compare
dzuelke
approved these changes
Sep 14, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR first detects if
jobs:workexist before adding it as a default task.Similar to #806 but it uses the existing RakeRunner object and also adds testing.
Special thanks to @JacobEvelyn for the original PR and the motivation.