[close #797] Do not carry asset pipeline fragment cache into runtime #812
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
schneems
force-pushed
the
schneems/no-assets-cache-at-runtime
branch
from
a168296
to
9fc1cd3
Compare
schneems
force-pushed
the
schneems/no-assets-cache-at-runtime
branch
2 times, most recently
from
2087ced
to
1d70e6e
Compare
jmorrell
approved these changes
Oct 17, 2018
schneems
force-pushed
the
schneems/no-assets-cache-at-runtime
branch
from
1d70e6e
to
b78d39a
Compare
When someone is using the asset pipeline, and they've disabled the config that allows them to build assets in production. So when ``` config.assets.compile = false ``` Then the `tmp/cache/assets/sprockets/` folder is not needed at runtime and should be safe to delete, which will lower the overall slug size. Do not merge until after Dreamforce.
schneems
force-pushed
the
schneems/no-assets-cache-at-runtime
branch
from
b78d39a
to
7303f8f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When someone is using the asset pipeline, and they've disabled the config that allows them to build assets in production.
So when
Then the
tmp/cache/assets/sprockets/folder is not needed at runtime and should be safe to delete, which will lower the overall slug size.Do not merge until after Dreamforce.