Close #84 Allow apps to enable RUBYOPT=--jit
#848
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
schneems
force-pushed
the
schneems/no-more-RUBYOPT
branch
from
3195691
to
4af3706
Compare
If you set: ``` $ heroku config:set RUBYOT=--jit ``` Then this will be a global value so when the buildpack attempts to detect ruby version by running: ``` $ bundle platform --ruby ``` It is executed with the RUBYOPT set. Since the version of Ruby the buildpack executes does not have `--jit` it fails: ``` -----> Ruby app detected -----> Compiling Ruby/Rails ! ! There was an error parsing your Gemfile, we cannot continue ! ruby: invalid option --jit (-h will show valid options) (RuntimeError) ! ! Push rejected, failed to compile Ruby app. ! Push failed ```
schneems
force-pushed
the
schneems/no-more-RUBYOPT
branch
from
4af3706
to
16795ef
Compare
schneems
changed the title
RUBYOPT=--jitRUBYOPT=--jit
hone
approved these changes
Jan 10, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you set:
Then this will be a global value so when the buildpack attempts to detect ruby version by running:
It is executed with the RUBYOPT set. Since the version of Ruby the buildpack executes does not have
--jitit fails: