Ignore invalid byte encodings when detecting rails config #854
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmorrell
approved these changes
Feb 13, 2019
Previously if a customer had an invalid byte sequence emitted during boot up, it would raise an error: ``` invalid byte sequence in UTF-8 ``` Which would prevent configuration detection from functioning correctly. When detecting rails configuration, we know that the input we are trying to detect for success will be UTF-8. As a result, we can ignore any other encoded characters. This PR prevents an invalid byte sequence from blocking rails configuration detection. Reference internal support ticket number: 681812 Here's a blog post on invalid byte sequences if you're interested https://thoughtbot.com/blog/fight-back-utf-8-invalid-byte-sequences.
schneems
force-pushed
the
schneems/fix-bytes
branch
from
21f7365
to
568afac
Compare
|
This has been deployed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously if a customer had an invalid byte sequence emitted during boot up, it would raise an error:
Which would prevent configuration detection from functioning correctly.
When detecting rails configuration, we know that the input we are trying to detect for success will be UTF-8. As a result, we can ignore any other encoded characters.
This PR prevents an invalid byte sequence from blocking rails configuration detection.
Reference internal support ticket number: 681812
Here's a blog post on invalid byte sequences if you're interested https://thoughtbot.com/blog/fight-back-utf-8-invalid-byte-sequences.