Include origin of versions in build output #50
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously the build output only stated what version of GDAL/GEOS/PROJ was being installed, and not why that version was chosen. In particular, this made the "the version you requested doesn't exist for this stack" message confusing for the case where the user didn't pick a version, but instead the version was inherited from the previous build via the cache. Now, the origin of the versions is logged. In addition, the "version not available for this stack" message has been tweaked to not (falsely) suggest the version was always explicitly requested, plus explain how to adjust the version using the env var or clearing the build cache. These changes should make stack upgrades less frustrating (such as for the upcoming Heroku-24 release). Lastly, some best practices have been applied to the curl usage.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously the build output only stated what version of GDAL/GEOS/PROJ was being installed, and not why that version was chosen.
In particular, this made the "the version you requested doesn't exist for this stack" message confusing for the case where the user didn't pick a version, but instead the version was inherited from the previous build via the cache.
Now, the origin of the versions is logged.
In addition, the "version not available for this stack" message has been tweaked to not (falsely) suggest the version was always explicitly requested, plus explain how to adjust the version using the env var or clearing the build cache.
These changes should make stack upgrades less frustrating (such as for the upcoming Heroku-24 release).
Lastly, some best practices have been applied to the curl usage.
GUS-W-15803983.