feat!(win32): allow install and just no-op unsupported operations #288
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
all the methods are no-op on windows always returning false
|
Waiting for GitHub actions incident to resolve and service to be back up before merging. |
hertzg
force-pushed
the
feat-noop-on-win32
branch
from
778ce88
to
e85b7ad
Compare
Codecov Report
@@ Coverage Diff @@
## master #288 +/- ##
===========================================
- Coverage 100.00% 98.50% -1.50%
===========================================
Files 4 4
Lines 118 134 +16
===========================================
+ Hits 118 132 +14
- Misses 0 2 +2
Continue to review full report at Codecov.
|
hertzg
changed the title
hertzg
added a commit
that referenced
this pull request
Aug 11, 2021
* feat: allow windows installs all the methods are no-op on windows always returning false * feat: run actions on windows * chore: update docs * feat!: guard against nullish descriptors
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just to allow installs on windows, refactored a bit the ffi to provide "no-op" methods instead of actual ffi calls.
This would be considered as a breaking change and will cause a new major version release.
Ref: #264