Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(context): no longer extend from eventEmitter #489

Merged
merged 1 commit into from
Aug 15, 2023
Merged

fix(context): no longer extend from eventEmitter #489

merged 1 commit into from
Aug 15, 2023

Conversation

stevenjoezhang
Copy link
Member

Close #488

@coveralls
Copy link

coveralls commented Aug 12, 2023 •
edited
Loading

Coverage Status

coverage: 84.03% (-0.1%) from 84.151% when pulling 09c0b76 on fix-context into 0ef5576 on master.

@stevenjoezhang stevenjoezhang merged commit 221ad65 into master Aug 15, 2023
15 of 20 checks passed
@stevenjoezhang stevenjoezhang deleted the fix-context branch August 15, 2023 03:51
@GhostDog98 GhostDog98 mentioned this pull request Oct 2, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yoshinorin yoshinorin yoshinorin approved these changes

@SukkaW SukkaW SukkaW approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Just a dev question - Why extend from eventEmitter when the methods are never used (hexo-cli) ?
4 participants
@stevenjoezhang @coveralls @yoshinorin @SukkaW