Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

some fixes as description #70

Closed
wants to merge 18 commits into from
Closed

some fixes as description #70

wants to merge 18 commits into from

Conversation

dimaslanjaka
Copy link
Contributor

@dimaslanjaka dimaslanjaka commented May 6, 2023 •
edited
Loading

fix: types node

install @types/node instead override type: node

feat: enable ESModule imports

fix: failed build caused by missing lib

Skip type checking of declaration files from node_modules. This can save time during compilation at the expense of type-system accuracy

chore: separate result type and make options as optional

separate result type

refactor: implement lint-staged and husky

to automatically fix code style before commited

SukkaW
SukkaW requested changes May 6, 2023
View reviewed changes
lib/front_matter.ts Outdated Show resolved Hide resolved
lib/front_matter.ts Show resolved Hide resolved
@dimaslanjaka dimaslanjaka requested a review from SukkaW May 6, 2023 07:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SukkaW SukkaW Awaiting requested review from SukkaW

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dimaslanjaka @SukkaW