Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some fixed as description #71

Closed
wants to merge 0 commits into from
Closed

Conversation

dimaslanjaka
Copy link
Contributor

@dimaslanjaka dimaslanjaka commented May 6, 2023

PR1

PR: #77

chore(regex): fixed parsing for CRLF

fix for sometimes changing post from github directly
which doesnt have auto trim whitespaces while saving file

PR2

PR: #76

fix: types node

install @types/node instead override type: node. this method will fixed typescript build for both single project or workspaces/monorepo project.

refactor: enable esModuleInterop

  • the ES6 modules spec states that a namespace import (import * as x) can only be an object, by having TypeScript treating it the same as = require("x") then TypeScript allowed for the import to be treated as a function and be callable. That's not valid according to the spec.

  • while accurate to the ES6 modules spec, most libraries with CommonJS/AMD/UMD modules didn't conform as strictly as TypeScript's implementation.

Turning on esModuleInterop will fix both of these problems in the code transpiled by TypeScript. see more

fix: failed build caused by missing lib

Skip type checking of declaration files from node_modules. This can save time during compilation at the expense of type-system accuracy.

chore: separate result type and make options as optional

separate result type

docs: add JSDoc

  • add JSDoc to HexoJS post metadata type

refactor: implement lint-staged and husky

to automatically fix code style before commited (temporary disabled)

new changes

  • drop prettier from lint-staged config
  • disable automatic init husky and lint-staged (we can manually activate or deactivate husky)

@dimaslanjaka
Copy link
Contributor Author

@SukkaW review pls

Copy link
Member

@yoshinorin yoshinorin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you please separate the pull request into two parts? type fixes and the others (such as prettier and husky).

To be honest, there is a possibility that we cannot accept the installation of prettier and husky.

.husky/pre-commit Outdated Show resolved Hide resolved
lint-staged.config.js Outdated Show resolved Hide resolved
@dimaslanjaka
Copy link
Contributor Author

dimaslanjaka commented May 13, 2023

Would you please separate the pull request into two parts? type fixes and the others (such as prettier and husky).

To be honest, there is a possibility that we cannot accept the installation of prettier and husky.

  1. PR to fix CRLF end of line regex chore: Fix CRLF end of line regex #77
  2. PR to fix failed build chore: Separate result options & Improve TSConfig #76

Test CI https:/dimaslanjaka/hexo-front-matter/actions

@dimaslanjaka
Copy link
Contributor Author

already separated PR, pls review again

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants