Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: cast type ConsoleArgs to any[] #148

Merged
merged 4 commits into from
May 10, 2023
Merged

chore: cast type ConsoleArgs to any[] #148

merged 4 commits into from
May 10, 2023

Conversation

dimaslanjaka
Copy link
Contributor

@dimaslanjaka dimaslanjaka commented May 6, 2023 •
edited
Loading

fixed for logging an object in typescript.

type non string is not assignable to type 'string'.ts(2322)

example

hexo.log.info('logname', { prop: 'value' });

error

Type '{ prop: string }' is not assignable to type 'string'. ts(2345)

@dimaslanjaka
Copy link
Contributor Author

@SukkaW review pls

SukkaW
SukkaW reviewed May 10, 2023
View reviewed changes
lib/log.ts Outdated Show resolved Hide resolved
@dimaslanjaka @SukkaW
chore: cast ConsoleArgs to any[]
3e1f6b6 
because just wrapper of `console.log`

Co-authored-by: Sukka <[email protected]>
@dimaslanjaka dimaslanjaka changed the title cast type ConsoleArgs to any[] chore: cast type ConsoleArgs to any[] May 10, 2023
@coveralls
Copy link

Coverage Status

Coverage: 98.413%. Remained the same when pulling 3e1f6b6 on dimaslanjaka:master into 97b563f on hexojs:master.

renbaoshuo
renbaoshuo approved these changes May 10, 2023
View reviewed changes
Copy link
Member

@renbaoshuo renbaoshuo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution!

@renbaoshuo renbaoshuo merged commit d20a133 into hexojs:master May 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SukkaW SukkaW SukkaW approved these changes

@renbaoshuo renbaoshuo renbaoshuo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dimaslanjaka @coveralls @SukkaW @renbaoshuo