Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove useless file from npm module #27

Merged
merged 2 commits into from
Jan 18, 2019
Merged

remove useless file from npm module #27

merged 2 commits into from
Jan 18, 2019

Conversation

tomap
Copy link
Contributor

@tomap tomap commented Dec 2, 2018

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling b77b176 on tomap:master into 1534374 on hexojs:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling b77b176 on tomap:master into 1534374 on hexojs:master.

@coveralls
Copy link

coveralls commented Dec 2, 2018 •
edited
Loading

Coverage Status

Coverage remained the same at 100.0% when pulling 6d353d7 on tomap:master into 1534374 on hexojs:master.

@tomap
Copy link
Contributor Author

tomap commented Dec 8, 2018

I used files in package.json to be more future proof
test with npm pack --dry-run

@tomap
Copy link
Contributor Author

tomap commented Jan 18, 2019

Up, I used files to exclude unnecessary files. could we merge?

yoshinorin
yoshinorin approved these changes Jan 18, 2019
View reviewed changes
Copy link
Member

@yoshinorin yoshinorin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

@yoshinorin yoshinorin merged commit 7e6a41f into hexojs:master Jan 18, 2019
@snyk-bot snyk-bot mentioned this pull request Mar 16, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yoshinorin yoshinorin yoshinorin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tomap @coveralls @yoshinorin