-
-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(url_for): some improvement for url_for
#307
Merged
Merged
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
1e892fb
chore: re-order types property
dimaslanjaka 77e9359
refactor: change prepare to postinstall
dimaslanjaka 2960b21
refactor: fix TS2550 - add lib `es2020`, `es2019`
dimaslanjaka 138d0d0
refactor: run build highlight before compile ts
dimaslanjaka dcfac4b
Merge branch 'hexojs:master' into monorepo
dimaslanjaka bde8887
feat(url_for): add type `options`
dimaslanjaka 8e9c249
docs(url_for): add JSDoc
dimaslanjaka 8663c65
refactor: remove highlight.js build from build script
dimaslanjaka 8aaa9e0
fix: invalid JSDoc usage
dimaslanjaka ab87569
Merge remote-tracking branch 'origin' into fix_url_for
uiolee a105304
rename UrlForOptions
uiolee b045658
rename UrlForOptions
uiolee File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can keep the original code style here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like he used prettier. If eslint doesn't fail, I guess it doesn't matter.