Merge pull request #1973 from matthew-andrews/updated-time

Add tests for og:updated_time in open_graph helper, and add ability to turn it off
hexojs · May 23, 2016 · a293755 · a293755
2 parents 569856e + 54404d5
commit a293755
Show file tree

Hide file tree

Showing 2 changed files with 33 additions and 1 deletion.
diff --git a/lib/plugins/helper/open_graph.js b/lib/plugins/helper/open_graph.js
@@ -37,7 +37,7 @@ function openGraphHelper(options) {
  var url = options.url || this.url;
  var siteName = options.site_name || config.title;
  var twitterCard = options.twitter_card || 'summary';
- var updated = options.updated || page.updated;
+ var updated = options.updated !== false ? (options.updated || page.updated) : false;
  var result = '';
 
  if (!Array.isArray(images)) images = [images];

diff --git a/test/scripts/helpers/open_graph.js b/test/scripts/helpers/open_graph.js
@@ -1,5 +1,6 @@
 'use strict';
 
+var moment = require('moment');
 var should = require('chai').should(); // eslint-disable-line
 
 describe('open_graph', function() {
@@ -371,4 +372,35 @@ describe('open_graph', function() {
 
  result.should.contain(meta({property: 'fb:app_id', content: '123456789'}));
  });
+
+ it('updated - options', function() {
+ var result = openGraph.call({
+ page: { updated: moment('2016-05-23T21:20:21.372Z') },
+ config: {},
+ is_post: isPost
+ }, { });
+
+ result.should.contain(meta({property: 'og:updated_time', content: '2016-05-23T21:20:21.372Z'}));
+ });
+
+ it('updated - options - allow overriding og:updated_time', function() {
+ var result = openGraph.call({
+ page: { updated: moment('2016-05-23T21:20:21.372Z') },
+ config: {},
+ is_post: isPost
+ }, { updated: moment('2015-04-22T20:19:20.371Z') });
+
+ result.should.contain(meta({property: 'og:updated_time', content: '2015-04-22T20:19:20.371Z'}));
+ });
+
+ it('updated - options - allow disabling og:updated_time', function() {
+ var result = openGraph.call({
+ page: { updated: moment('2016-05-23T21:20:21.372Z') },
+ config: {},
+ is_post: isPost
+ }, { updated: false });
+
+ result.should.not.contain(meta({property: 'og:updated_time', content: '2016-05-23T21:20:21.372Z'}));
+ });
+
 });