Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Data URI scheme for og:image #5052

Closed
2 tasks done
KentarouTakeda opened this issue Sep 7, 2022 · 0 comments · Fixed by #5053
Closed
2 tasks done

Data URI scheme for og:image #5052

KentarouTakeda opened this issue Sep 7, 2022 · 0 comments · Fixed by #5053

Comments

@KentarouTakeda
Copy link
Contributor

KentarouTakeda commented Sep 7, 2022

Check List

Please check followings before submitting a new feature request.

  • I have already read Docs page
  • I have already searched existing issues

Feature Request

open_graph helper should not generate og:image of data-uri.

It's basically correct to output all image URLs in the article as og:image.

By the way, the "URL" in OGP must be https://, but open_graph() also handles Data URI schemes. As a result, many OGP crawlers seem to treat it as an error.

NOTE: The Open Graph protocol / Types / URL
https://ogp.me/#url

All valid URLs that utilize the https:// or https:// protocols

This error should be prevented.

Others

This issue is now reproduced on my blog.
https://no-hack-no.life/post/2022-08-01-want-ERD-to-become-more-popular/

The images used in the above URLs are all data-uri as follows:
1 my-post-entry

When this URL is loaded into Meta OGP Share Debugger, the following error occurs.
https://developers.facebook.com/tools/debug/?q=https%3A%2F%2Fno-hack-no.life%2Fpost%2F2022-08-01-want-ERD-to-become-more-popular%2F

2 result-of-share-debugger

All settings are here, including package.json and _config.json.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant