New date helper using momentjs 'fromNow' method #1350
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
June 23, 2015 22:41
Moment.js provides a quite useful function for relative time, it would be a shame not to use it ;)
|
Looks wonderful~ |
| @@ -5,17 +5,21 @@ var isMoment = moment.isMoment; | |||
| var isDate = require('util').isDate; | |||
|
|
|||
| function output(date, format, lang, timezone){ | |||
| if (date == null) date = moment(); | |||
| if (typeof myVar === 'undefined' || date === null) date = moment(); | |||
There was a problem hiding this comment.
== null can detect both undefined and null.
|
It's not a good idea to write |
|
@tommy351 Is it better like this, only checking for |
|
I think you can rename the |
…r format the date
|
Better ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moment.js provides a quite useful function for relative time, it would be a shame not to use it ;)