Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(helper/open_graph): use whatwg url api #5007

Merged
merged 1 commit into from
Jun 24, 2022

Conversation

renbaoshuo
Copy link
Member

What does it do?

Use WHATWG URL API instead of the deprecated url in open_graph() helper.

Screenshots

None.

Pull request tasks

  • Add test cases for the changes. Not needed.
  • Passed the CI test.

@github-actions
Copy link

How to test

git clone -b helper-open_graph-url https:/renbaoshuo/hexo.git
cd hexo
npm install
npm test

@coveralls
Copy link

coveralls commented Jun 23, 2022

Coverage Status

Coverage decreased (-0.003%) to 98.004% when pulling 176fafd on renbaoshuo:helper-open_graph-url into 24db105 on hexojs:master.

test/scripts/helpers/open_graph.js Outdated Show resolved Hide resolved
@SukkaW SukkaW merged commit 3bd5f2b into hexojs:master Jun 24, 2022
@renbaoshuo renbaoshuo deleted the helper-open_graph-url branch July 14, 2022 02:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants