Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

revert(categories,tags): revert behavior of locals.tags and locals.categories #5388

Merged
merged 1 commit into from
Apr 14, 2024

Conversation

uiolee
Copy link
Member

@uiolee uiolee commented Dec 28, 2023

#5380 (comment)

What does it do?

revert some changes of #5119

fix #5380
fix #5367

Screenshots

Pull request tasks

  • Add test cases for the changes.
  • Passed the CI test.

Copy link

How to test

git clone -b fix_categories_tags https:/hexojs/hexo.git
cd hexo
npm install
npm test

@uiolee uiolee changed the title fix(categories,tags): revert behavior of locals.tags and locals.categories revert(categories,tags): revert behavior of locals.tags and locals.categories Jan 14, 2024
@D-Sketon D-Sketon mentioned this pull request Jan 19, 2024
2 tasks
@D-Sketon
Copy link
Member

D-Sketon commented Apr 6, 2024

any update?

@uiolee
Copy link
Member Author

uiolee commented Apr 6, 2024

IDK

@stevenjoezhang
Copy link
Member

I remember #3624 was to solve a problem theme-next/hexo-theme-next#42, and the #5119 was to speed up rendering. The problem wasn't completely solved, and we will need to consider better solutions in the future.
Additionally, we need to advise theme developers not to use private properties of the warehouse objects.

@yoshinorin yoshinorin merged commit b6ebbca into master Apr 14, 2024
21 of 30 checks passed
@yoshinorin yoshinorin deleted the fix_categories_tags branch April 14, 2024 02:37
dimaslanjaka pushed a commit to dimaslanjaka/hexo that referenced this pull request Oct 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants