Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

plugins: add hexo-bin-pagination #2018

Merged
merged 1 commit into from
Sep 3, 2023
Merged

plugins: add hexo-bin-pagination #2018

merged 1 commit into from
Sep 3, 2023

Conversation

CroMarmot
Copy link
Contributor

Check List

Please read and check followings before submitting a PR.

  • I want to publish my theme on Hexo official website.
    • I have read the theme publishing doc.
    • name is unique.
    • link URL is correct.
    • preview URL is correct.
    • preview URL web site is rendered correctly.
    • Add a screenshot to source/themes/screenshots.
    • Screenshot filename is same as value of name.
    • Screenshot size is 800 * 500.
    • Screenshot file format is png.
  • I want to publish my plugin on Hexo official website.
  • Others (Update, fix, translation, etc...)
    • Languages:
    • en English
    • ru Russian
    • zh-cn simplified Chinese
    • zh-tw traditional Chinese

Note

No need to translate ko, pt-br, th languages if you submit a PR for documentation.

Warning

ko, pt-br, th languages document are inactive. Please, submit issue if you want to continuous contribution to them.

@github-actions
Copy link
Contributor

Theme name validation passed.
Theme thumbnails validation completed.

@uiolee uiolee changed the title docs: add plugins data: hexo-bin-pagination plugins: add plugins data: hexo-bin-pagination Aug 31, 2023
yoshinorin
yoshinorin requested changes Sep 1, 2023
View reviewed changes
Copy link
Member

@yoshinorin yoshinorin left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are splitted the plugins files in #2038.
Please submit PR again. We apologize for the inconvinence.

@CroMarmot
Copy link
Contributor Author

@yoshinorin PR updated

@uiolee uiolee changed the title plugins: add plugins data: hexo-bin-pagination plugins: add hexo-bin-pagination Sep 2, 2023
yoshinorin
yoshinorin approved these changes Sep 3, 2023
View reviewed changes
Copy link
Member

@yoshinorin yoshinorin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you :)

@yoshinorin yoshinorin merged commit 4b32562 into hexojs:master Sep 3, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yoshinorin yoshinorin yoshinorin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@CroMarmot @yoshinorin