Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(helpers): fix a slight error #2023

Closed
wants to merge 14 commits into from
Closed

docs(helpers): fix a slight error #2023

wants to merge 14 commits into from

Conversation

Fgaoxing
Copy link

@Fgaoxing Fgaoxing commented Jun 11, 2023 •
edited
Loading

Check List

Please read and check followings before submitting a PR.

  • I want to publish my theme on Hexo official website.
    • I have read the theme publishing doc.
    • name is unique.
    • link URL is correct.
    • preview URL is correct.
    • preview URL web site is rendered correctly.
    • Add a screenshot to source/themes/screenshots.
    • Screenshot filename is same as value of name.
    • Screenshot size is 800 * 500.
    • Screenshot file format is png.
  • I want to publish my plugin on Hexo official website.
  • Others (Update, fix, translation, etc...)
    • Languages:
    • en English
    • ru Russian
    • zh-cn simplified Chinese
    • zh-tw traditional Chinese

Note

No need to translate ko, pt-br, th languages if you submit a PR for documentation.

Warning

ko, pt-br, th languages document are inactive. Please, submit issue if you want to continuous contribution to them.

@Fgaoxing Fgaoxing mentioned this pull request Jun 11, 2023
Closed
@github-actions
Copy link
Contributor

Theme name validation passed.
Theme thumbnails validation completed.

@stevenjoezhang stevenjoezhang linked an issue Jun 12, 2023 that may be closed by this pull request
A slight error regarding the helpers.md document #2024
Closed
stevenjoezhang
stevenjoezhang reviewed Jun 14, 2023
View reviewed changes
source/docs/helpers.md
@@ -272,7 +272,7 @@ Option | Description | Default
// <link rel="alternate" href="/atom.xml" title="Hexo" type="application/atom+xml">

<%- feed_tag('rss.xml', { title: 'RSS Feed', type: 'rss' }) %>
// <link rel="alternate" href="/atom.xml" title="RSS Feed" type="application/atom+xml">
// <link rel="alternate" href="/rss.xml" title="RSS Feed" type="application/atom+xml">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should it be type="application/atom+xml" or type="application/rss+xml"?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

的确，一会改
Indeed, it will be changed later

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

但具体要看这个helper的实际内容

@Fgaoxing Fgaoxing closed this Jul 14, 2023
@Fgaoxing Fgaoxing reopened this Jul 14, 2023
@Fgaoxing
Copy link
Author

@tomap

@Fgaoxing
Copy link
Author

@tomap Est - il possible de passer ma soumission, s'il vous plaît? May I ask if I can submit it? 请问可以通过我的提交吗？

uiolee
uiolee reviewed Aug 15, 2023
View reviewed changes
source/docs/helpers.md
@@ -272,7 +272,7 @@ Option | Description | Default
// <link rel="alternate" href="/atom.xml" title="Hexo" type="application/atom+xml">

<%- feed_tag('rss.xml', { title: 'RSS Feed', type: 'rss' }) %>
// <link rel="alternate" href="/atom.xml" title="RSS Feed" type="application/atom+xml">
// <link rel="alternate" href="/rss.xml" title="RSS Feed" type="application/atom+xml">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
// <link rel="alternate" href="/rss.xml" title="RSS Feed" type="application/atom+xml">
// <link rel="alternate" href="/rss.xml" title="RSS Feed" type="application/rss+xml">

@uiolee uiolee changed the title A slight error regarding the helpers.md document docs: A slight error regarding the helpers.md document Sep 2, 2023
@uiolee uiolee changed the title docs: A slight error regarding the helpers.md document docs(helpers): fix a slight error Sep 25, 2023
@uiolee uiolee marked this pull request as draft October 19, 2023 15:12
@uiolee uiolee added Docs source/docs zh lang: zh-cn && zh-tw en lang: en labels Oct 23, 2023
@uiolee uiolee added pt-br lang: pt-br ru lang: ru th labg: th labels Oct 23, 2023
@Fgaoxing Fgaoxing closed this by deleting the head repository Jan 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stevenjoezhang stevenjoezhang stevenjoezhang left review comments

@uiolee uiolee uiolee left review comments

@tomap tomap tomap approved these changes

Assignees
No one assigned
Labels
Docs source/docs en lang: en pt-br lang: pt-br ru lang: ru th labg: th zh lang: zh-cn && zh-tw
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

A slight error regarding the helpers.md document
4 participants
@Fgaoxing @tomap @stevenjoezhang @uiolee