Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

plugin: add hexo-shiki-twoslash #2252

Closed
wants to merge 1 commit into from
Closed

plugin: add hexo-shiki-twoslash #2252

wants to merge 1 commit into from

Conversation

noraj
Copy link
Contributor

@noraj noraj commented Sep 12, 2024

Check List

Please read and check followings before submitting a PR.

  • I want to publish my theme on Hexo official website.
    • I have read the theme publishing doc.
    • name is unique.
    • link URL is correct.
    • preview URL is correct.
    • preview URL web site is rendered correctly.
    • Add a screenshot to source/themes/screenshots.
    • Screenshot filename is same as value of name.
    • Screenshot size is 800 * 500.
    • Screenshot file format is png.
  • I want to publish a plugin on Hexo official website.
  • Others (Update, fix, translation, etc...)
    • Languages:
    • en English
    • ru Russian
    • zh-cn simplified Chinese
    • zh-tw traditional Chinese
    • ja Japanese

Note

No need to translate ko, pt-br, th languages if you submit a PR for documentation.

Warning

ko, pt-br, th languages document are inactive. Please, submit issue if you want to continuous contribution to them.

yoshinorin
yoshinorin requested changes Sep 19, 2024
View reviewed changes
Copy link
Member

@yoshinorin yoshinorin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@noraj
We are splitted the plugins files in #2038.
Please submit the PR again.

Thank you :)

@noraj
Copy link
Contributor Author

noraj commented Sep 21, 2024

@yoshinorin What do you mean? I have modified source/_data/plugins.yml, not an old unified fyaml.

uiolee
uiolee requested changes Sep 23, 2024
View reviewed changes
Copy link
Member

@uiolee uiolee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

checklist

If you want to add content, please follow the documentation's guidelines

@uiolee uiolee closed this Sep 23, 2024
@noraj
Copy link
Contributor Author

noraj commented Sep 23, 2024

I read the doc in the past, I was just not aware it changed.

@noraj
Copy link
Contributor Author

noraj commented Sep 23, 2024

fixed in #2258

@noraj noraj deleted the noraj/hexo-shiki-twoslash branch September 23, 2024 19:12
@noraj noraj mentioned this pull request Sep 23, 2024
Merged
20 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yoshinorin yoshinorin yoshinorin requested changes

@uiolee uiolee uiolee requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@noraj @yoshinorin @uiolee