refactor: re-implement JSONStream #133
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SukkaW
force-pushed
the
replace-jsonstream
branch
from
546f77c
to
235b0db
Compare
renbaoshuo
approved these changes
Jul 28, 2022
5 tasks
|
Should we release a new version of this package after merging this PR? |
yoshinorin
pushed a commit
that referenced
this pull request
Jul 28, 2022
yoshinorin
added a commit
that referenced
this pull request
Jul 29, 2022
Co-authored-by: Sukka <[email protected]>
Done :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #132.
Instead of relying on a community fork (which is unstable, not widely used and tested, and could break at any time), I re-implement the
JSONStream(but usesthrough2instead) in this PR as a replacement.Only the
parsefunction is implemented (withoutstringify) which also reduces the package size.