refactor: refactor types #230
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 7492170366
💛 - Coveralls |
uiolee
previously approved these changes
Dec 21, 2023
SukkaW
previously approved these changes
Dec 21, 2023
SukkaW
reviewed
Dec 21, 2023
D-Sketon
commented
Dec 23, 2023
| abstract _model: Model<T>; | ||
| _id!: string | number | undefined; | ||
| abstract _schema: Schema; | ||
| [key : string]: any; |
There was a problem hiding this comment.
I'm not sure how this can be modified to use the indexes in the generalized type.
There was a problem hiding this comment.
SukkaW
requested changes
Dec 24, 2023
src/types/array.ts
Outdated
Comment on lines
36
to
40
| cast(value_: Exclude<unknown, null | undefined>, data?: unknown): I[]; | ||
| cast(value_?: unknown, data?: unknown): I[] | null | undefined; | ||
| cast(value_?: unknown, data?: unknown): I[] | null | undefined { | ||
| value_ = super.cast(value_, data); | ||
| if (value_ == null) return value_ as null | undefined; |
There was a problem hiding this comment.
IMHO the type of SchemaType#cast should also be improved to avoid the as here.
uiolee
previously approved these changes
Dec 28, 2023
|
Please submit a release PR if we need to release a new version after merge this PR. |
uiolee
approved these changes
Jan 11, 2024
SukkaW
approved these changes
Jan 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.