Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add hypen-minus 002D, and make various improvements. #426

Merged
merged 15 commits into from
Jan 6, 2023

Conversation

RobertWinslow
Copy link
Contributor

@RobertWinslow RobertWinslow commented Dec 24, 2022

A src vector for the hyphen-minus symbol (codepoint 002D) has been added, as suggested in the discussion in #93

Additionally, several src vectors have been modified:

  • Several paths have had superfluous colinear points removed (tophat and math symbols).
  • Several math symbols were centered.
  • 1FAD7 (pouring liquid) was reworked to have thicker lines.
  • The lines in 1F6EB and 1F6EC (airplane takeoff and landing) were likewise thickened.
  • The post office symbol in 1F3E3 was made blockier and red.
  • 1F691 (ambulance) was updated to have the correct symbol, the Star of Life.
  • The black version of the moon phases now has a black fill.
  • 1F5C2 and 1F4C7 have made more distinct, with 1F4C7 redesigned to be more similar to other emoji sets.
  • The black flag 1F3F4 has had a path closed and reversed. This shouldn't alter the appearance of the image, but will hopefully fix a font rendering error.
  • Lighten the background of 1F233
  • The 'E' in 1F4E7 (e-mail) has been rounded and copied into the line-supplement layer.

This pull request should hopefully fully address the following issues:

These symbols were off-center and had superfluous points.
I redid the point positions, making them cleaner and more consistent,  while keeping the shapes roughly the same.
The outline of the hat had some colinear points that didn't affect the appearance of the curve at all. The fill of the top of the hat had those same points and also the colinear points lower down on the hat. For an object without a stroke, those aren't even visible.
The changes to the planes are fairly minimal. The changes to the pouring cup are more extensive and still could use some improvement.

Fixes hfg-gmuend#408
The post office symbol has been made red and composed of rectangles.
A black copy of the symbol has been included in the line-supplement layer.
As per suggestion in hfg-gmuend#417

I also added a red stripe for visual interest and added both star and stripe to the line-supplement layer.
Addresses hfg-gmuend#387

I added black copies of the darkened portions of each moon phase. This makes the glyphs consistent with the designs in the monochrome Noto emoji font.
As suggested in hfg-gmuend#361
- Card Index Dividers 1F5C2 is made yellow.
- Card Index 1F4C7 is completely redesigned.
Small change to make my additions consistent with the style guide, which says "Use the lighter colours as default colours and reserve the darker colors for shadowing."
This should hopefully improve the rendering of the black-font version of 1F3F4, black flag.
Addresses one of the complaints in hfg-gmuend#418
There were two issues fixed in this commit:
- The E in the email symbol had square corners instead of round corners.
- The E wasn't showing up at all in the black monochrome output.

I set `stroke-linejoin="round"` and copied the E into the line-supplement layer.
@b-g
Copy link
Member

b-g commented Jan 6, 2023

@RobertWinslow Mega! Many thanks for this great contribution! Merged!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants