Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add packaging to the dependencies #1077

Merged
merged 1 commit into from
Apr 16, 2020
Merged

Conversation

keewis
Copy link
Contributor

@keewis keewis commented Apr 12, 2020

Since a few people reported trouble with the setuptools vendoring mechanism (mainly because the ArchLinux package of setuptools does not include the vendoring part), this makes pint depend directly on packaging. We also depend on setuptools which in turn depends on packaging, but this way the dependency graph is more explicit.

We can revert this once we require numpy >= 1.16 and are able to remove the version check.

  • Closes Problem with Setuptools #1008 (@hgrecco, could you reopen that issue so we can close it?)
  • Executed black -t py36 . && isort -rc . && flake8 with no errors
  • The change is fully covered by automated unit tests
  • Documented in docs/ as appropriate
  • Added an entry to the CHANGES file

We already depended on it indirectly via setuptools, so this doesn't
change anything for library users.
@hgrecco
Copy link
Owner

hgrecco commented Apr 16, 2020

bors r+

@bors
Copy link
Contributor

bors bot commented Apr 16, 2020

Build succeeded:

@bors bors bot merged commit 878f81e into hgrecco:master Apr 16, 2020
@keewis keewis deleted the update-dependencies branch April 16, 2020 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Problem with Setuptools
2 participants