Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Provide dependencies at right scope #116

Closed
hieuwu opened this issue Oct 1, 2022 · 2 comments · Fixed by #139
Closed

Provide dependencies at right scope #116

hieuwu opened this issue Oct 1, 2022 · 2 comments · Fixed by #139
Assignees
@Devendra34
Labels
enhancement New feature or request good first issue Good for newcomers hacktoberfest

Comments

@hieuwu
Copy link
Owner

hieuwu commented Oct 1, 2022

Is your feature request related to a problem? Please describe.
Currently every dependencies is provided at @singleton scope. This is not a good approach. Some components like UseCase can be provided only when we need to use it in ViewModel

Describe the solution you'd like
Provide UseCases at ViewModelScope instead of Singleton

Describe alternatives you've considered
None
@hieuwu hieuwu added enhancement New feature or request hacktoberfest good first issue Good for newcomers labels Oct 1, 2022
@Devendra34
Copy link
Contributor

Hi @hieuwu,
Can I try for this issue?

@hieuwu
Copy link
Owner Author

hieuwu commented Oct 4, 2022

Hi @hieuwu, Can I try for this issue?

Sure. Please also explain your solution along with some document to refer. Thanks

This was referenced Oct 4, 2022
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Devendra34 Devendra34

Labels
enhancement New feature or request good first issue Good for newcomers hacktoberfest
Projects
Groceries Store
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Provided UseCases at ViewModelScope instead of Singleton Devendra34/android-groceries-store
2 participants
@hieuwu @Devendra34