Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Favourite page #127

Closed
Aditya-gupta99 opened this issue Oct 3, 2022 · 9 comments
Closed

Improve Favourite page #127

Aditya-gupta99 opened this issue Oct 3, 2022 · 9 comments
Assignees

Comments

@Aditya-gupta99
Copy link
Contributor

**Is your feature request related to a problem? Please describe
The favorite fragment does not seem to be as user-friendly as it should be.

Describe the solution you'd like
As I work on it, I will strive to make it as user-friendly as possible.

@hieuwu
Copy link
Owner

hieuwu commented Oct 3, 2022

**Is your feature request related to a problem? Please describe The favorite fragment does not seem to be as user-friendly as it should be.

Describe the solution you'd like As I work on it, I will strive to make it as user-friendly as possible.

Could you please give me some hints about what you will do?

@Aditya-gupta99
Copy link
Contributor Author

I will change the Cardview to make the favorite list look better. I would like to change the orientation of the action bar to match the overall theme.

@Aditya-gupta99
Copy link
Contributor Author

Similar to the shop home page

@hieuwu
Copy link
Owner

hieuwu commented Oct 3, 2022

Okay let's do it.

Similar to the shop home page

@hieuwu
Copy link
Owner

hieuwu commented Oct 4, 2022

Closed. Fixed in #129

@hieuwu hieuwu closed this as completed Oct 4, 2022
@hieuwu
Copy link
Owner

hieuwu commented Oct 5, 2022

@all-contributors please add @Aditya-gupta99 for his creativity in improving the favourite screen

@allcontributors
Copy link
Contributor

@hieuwu

I couldn't determine any contributions to add, did you specify any contributions?
Please make sure to use valid contribution names.

@hieuwu
Copy link
Owner

hieuwu commented Oct 5, 2022

@all-contributors please add @Aditya-gupta99 for design

@allcontributors
Copy link
Contributor

@hieuwu

I've put up a pull request to add @Aditya-gupta99! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants