Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add MiMa #135

Merged
merged 3 commits into from
Oct 29, 2019
Merged

Add MiMa #135

merged 3 commits into from
Oct 29, 2019

Conversation

travisbrown
Copy link
Collaborator

Put this together to verify that the current master could be published as 0.7.1. The exclusions are needed because of a MiMa bug I reported yesterday.

Because the project is pre-1.0 I haven't added the bincompat checking to the build, but you can confirm it manually like this:

sbt ++2.11.12 mimaReportBinaryIssues
sbt ++2.12.10 mimaReportBinaryIssues

@travisbrown
Copy link
Collaborator Author

Oh, I guess the next release will need to be 0.8.0 anyway, since droste-scalacheck and droste-laws have runtime dependencies on ScalaCheck, which we're updating from 1.13 to 1.14. In any case I think it's handy to have the MiMa checking in place.

@andyscott
Copy link
Member

Yep on both counts.

@travisbrown
Copy link
Collaborator Author

These stack overflows in the List and Stream tests are annoying—I ran into similar failures in Circe after 1.14.1 to 1.14.2 (I think it was that bump?). I guess we should probably reduce the Vector size instead of just the List or Stream size.

@andyscott
Copy link
Member

Yea, agreed. Feel free to merge regardless of the failing test-- we can fix that in another PR.

@travisbrown
Copy link
Collaborator Author

I've reduced the size in the Arbitrary instances in ListTests to match the new value in StreamTests.

I spent some time looking at more principled ways to fix the problem, and it seems like using AlgebraM[Eval, ...] and CoalgebraM[Eval, ...] for the List-ListF conversions might work, but I think that should be part of a bigger push for stack safety for those types, and the smaller size seems like a reasonable workaround to unflake the tests for now.

@travisbrown travisbrown merged commit 1558b21 into higherkindness:master Oct 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants