Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add classpath rewrite handling to mavencatalogresolver #13

Closed
jahutton opened this issue Oct 27, 2014 · 5 comments
Closed

Add classpath rewrite handling to mavencatalogresolver #13

jahutton opened this issue Oct 27, 2014 · 5 comments

Comments

@jahutton
Copy link

Running into an issue with multiple level of dependencies (C->B->A). It would be helpful if the MavenCatalogResolver would also handle the classpath protocols so that schemaLocations can remain as urls to be rewritten into maven uris in downstream projects.

@highsource
Copy link
Owner

Would please consider providing a test project to demonstrate the required feature?

@jahutton
Copy link
Author

I've forked it here https:/jahutton/maven-jaxb2-plugin with the relevant changes. It would just mean merging the logic from ClasspathCatalogResolver into MavenCatalogResolver.

@highsource
Copy link
Owner

Ok, I undestand the idea technically but don't understand, why would the
MavenCatalogResolver not be sufficient. I actually thought that the
ClasspathCatalogResolver is obsolete and functionally superceeded by the
MavenCatalogResolver.

On Mon, Oct 27, 2014 at 3:57 PM, jahutton [email protected] wrote:

I've forked it here https:/jahutton/maven-jaxb2-plugin with
the relavent changes. It would just mean merging the logic from
ClasspathCatalogResolver into MavenCatalogResolver.


Reply to this email directly or view it on GitHub
#13 (comment)
.

@jahutton
Copy link
Author

jahutton commented Nov 1, 2014

Ok, figured a solution to my problem just took some time to take a step back and re think it. I'll close this, however having the maven protocol self identify or allow extensions on the maven resolver could allow individuals needs to be met with out needing a pull.

The solution was to have one packaged catalog for the world (classpath for cxf) and one in a build location for jaxb.

@jahutton jahutton closed this as completed Nov 1, 2014
@highsource
Copy link
Owner

I'd still be grateful if you explain the original problem that you had. I actually don't mind adding classpath: support, I just wanted to make sure that it is reasonable.

By the way, you can configure your own resolvers using the catalogResolver configuration element. But they will replace the "default" one completely, not extend it. Please file an issue if you think this would be a good feature.

phax referenced this issue in phax/maven-jaxb2-plugin Sep 1, 2022
…-parent-pom-1.11.3

Bump parent-pom from 1.11.2 to 1.11.3
laurentschoelens pushed a commit to laurentschoelens/jaxb-tools that referenced this issue May 12, 2023
Issue highsource#11. Adding JUnit to compare against the Eclipse generator.
laurentschoelens pushed a commit to laurentschoelens/jaxb-tools that referenced this issue May 12, 2023
laurentschoelens pushed a commit to laurentschoelens/jaxb-tools that referenced this issue Aug 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants