Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement modals #1002

Merged
merged 51 commits into from
Dec 4, 2022
Merged

Implement modals #1002

merged 51 commits into from
Dec 4, 2022

Conversation

thesadru
Copy link
Contributor

@thesadru thesadru commented Feb 4, 2022

References

Checklist

ETA: 9 months ago

  • Make all pipelines pass
  • modal interaction response (sent to user)
    • builder
    • rest method
  • modal interaction event (gotten from user)
    • all attributes
    • all helper methods
    • respond with rest
    • respond with restbot
  • text input
    • interaction model
    • response builder
      • builder classes
      • helper methods
  • factory
    • modal
    • text input
  • tests
    • modal interaction response
      • rest
      • helper methods
    • modal interaction response builder
      • rest
      • helper methods
    • modal interaction event
      • entity factory
      • methods
    • text input builder
  • suggestions
    • helper method to add a single text input wrapped in an action row

Closes #1329

@thesadru thesadru force-pushed the feat/modal branch 2 times, most recently from 9122b92 to 59d815f Compare February 12, 2022 15:28
@thesadru thesadru marked this pull request as ready for review February 12, 2022 15:28
Copy link
Contributor

@Jonxslays Jonxslays left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

<3 sadru.

hikari/api/rest.py Outdated Show resolved Hide resolved
hikari/api/rest.py Outdated Show resolved Hide resolved
hikari/api/special_endpoints.py Outdated Show resolved Hide resolved
hikari/api/rest.py Outdated Show resolved Hide resolved
hikari/api/special_endpoints.py Outdated Show resolved Hide resolved
hikari/interactions/modal_interactions.py Outdated Show resolved Hide resolved
hikari/interactions/modal_interactions.py Outdated Show resolved Hide resolved
hikari/interactions/modal_interactions.py Outdated Show resolved Hide resolved
hikari/interactions/modal_interactions.py Outdated Show resolved Hide resolved
hikari/interactions/modal_interactions.py Outdated Show resolved Hide resolved
@hypergonial
Copy link
Contributor

Been testing it for about a week now, seems ready for final review.

changes/1002.feature.md Outdated Show resolved Hide resolved
hikari/api/special_endpoints.py Show resolved Hide resolved
hikari/impl/entity_factory.py Outdated Show resolved Hide resolved
hikari/impl/entity_factory.py Show resolved Hide resolved
hikari/impl/entity_factory.py Outdated Show resolved Hide resolved
hikari/interactions/modal_interactions.py Outdated Show resolved Hide resolved
hikari/interactions/modal_interactions.py Outdated Show resolved Hide resolved
hikari/messages.py Outdated Show resolved Hide resolved
hikari/messages.py Outdated Show resolved Hide resolved
hikari/messages.py Outdated Show resolved Hide resolved
@thesadru thesadru force-pushed the feat/modal branch 2 times, most recently from 716d950 to 5b7bd63 Compare March 5, 2022 16:39
I love having to deal with random changes in unrelated PRs.
@ghost
Copy link

ghost commented Mar 25, 2022

An issue with adding create_modal_response to MessageResponseMixin - you cannot respond to a modal with another modal so this gives incorrect suggestions for IDE autocomplete.

@davfsa davfsa mentioned this pull request Oct 19, 2022
2 tasks
@FasterSpeeding
Copy link
Collaborator

If ya could get some of ye last review thingies fixed i'da think this would be bout ready to merge

Copy link
Contributor

@yakMM yakMM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this works nicely for users and should be good for future evolution!

hikari/components.py Outdated Show resolved Hide resolved
hikari/impl/rest.py Show resolved Hide resolved
hikari/impl/rest.py Show resolved Hide resolved
hikari/impl/rest.py Outdated Show resolved Hide resolved
FasterSpeeding
FasterSpeeding previously approved these changes Dec 4, 2022
davfsa
davfsa previously approved these changes Dec 4, 2022
@davfsa davfsa enabled auto-merge (squash) December 4, 2022 21:34
@davfsa davfsa dismissed stale reviews from FasterSpeeding and themself via 5c9053a December 4, 2022 21:36
@davfsa davfsa merged commit b638e0c into hikari-py:master Dec 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Extract component models out of messages.py