-
-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement modals #1002
Implement modals #1002
Conversation
9122b92
to
59d815f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
<3 sadru.
Been testing it for about a week now, seems ready for final review. |
Fixed some issues with wording and copy-pasting.
716d950
to
5b7bd63
Compare
I love having to deal with random changes in unrelated PRs.
An issue with adding |
If ya could get some of ye last review thingies fixed i'da think this would be bout ready to merge |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, this works nicely for users and should be good for future evolution!
References
Checklist
ETA: 9 months ago
Closes #1329