Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(mdx): not replacing all img src #186

Merged
merged 1 commit into from
Aug 10, 2019
Merged

fix(mdx): not replacing all img src #186

merged 1 commit into from
Aug 10, 2019

Conversation

hbish
Copy link
Contributor

@hbish hbish commented Aug 10, 2019

  • bugfix
  • feature
  • code refactor
  • test update
  • docs update
  • chore update

Motivation / Use-Case

When there are multiple img srcs on the one slide. mdx-loader only correctly substitute the first src. Subsequent images fails to load.

image

@netlify
Copy link

netlify bot commented Aug 10, 2019

Deploy preview for heuristic-davinci-1cf783 ready!

Built with commit 493fe2a

https://deploy-preview-186--heuristic-davinci-1cf783.netlify.com

@hbish hbish changed the title fix mdxPlugin not replacing all img src fix(mdx): not replacing all img src Aug 10, 2019
Copy link
Owner

@hiroppy hiroppy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! thanks

@hiroppy hiroppy merged commit 6f13be9 into hiroppy:master Aug 10, 2019
@hiroppy
Copy link
Owner

hiroppy commented Aug 10, 2019

Released https:/hiroppy/fusuma/releases/tag/v1.14.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants