Separate change kinds #41
Merged
+175
−83
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kitagry
force-pushed
the
separate-change-kinds
branch
from
c9d665d
to
dea6a17
Compare
hirosassa
reviewed
May 12, 2024
src/template.rs
Outdated
Comment on lines
30
to
46
| {{#if (gt (len created_kinds) 0)}} | ||
| * created | ||
| {{#each created_kinds}} | ||
| * {{this}} | ||
| {{/each}} | ||
| {{/if}} | ||
| {{#if (gt (len pruned_kinds) 0)}} | ||
| * pruned | ||
| {{#each pruned_kinds}} | ||
| * {{this}} | ||
| {{/each}} | ||
| {{/if}} | ||
| {{#if (gt (len configured_kinds) 0)}} | ||
| * configured | ||
| {{#each configured_kinds}} | ||
| * {{this}} | ||
| {{/each}} |
There was a problem hiding this comment.
[comment] @kitagry
Did you consider using H2 (or smaller one) as a separator?
If not, I think it is good to compare the format.
Suggested change
| {{#if (gt (len created_kinds) 0)}} | |
| * created | |
| {{#each created_kinds}} | |
| * {{this}} | |
| {{/each}} | |
| {{/if}} | |
| {{#if (gt (len pruned_kinds) 0)}} | |
| * pruned | |
| {{#each pruned_kinds}} | |
| * {{this}} | |
| {{/each}} | |
| {{/if}} | |
| {{#if (gt (len configured_kinds) 0)}} | |
| * configured | |
| {{#each configured_kinds}} | |
| * {{this}} | |
| {{/each}} | |
| {{#if (gt (len created_kinds) 0)}} | |
| ## created | |
| {{#each created_kinds}} | |
| * {{this}} | |
| {{/each}} | |
| {{/if}} | |
| {{#if (gt (len pruned_kinds) 0)}} | |
| ## pruned | |
| {{#each pruned_kinds}} | |
| * {{this}} | |
| {{/each}} | |
| {{/if}} | |
| {{#if (gt (len configured_kinds) 0)}} | |
| ## configured | |
| {{#each configured_kinds}} | |
| * {{this}} | |
| {{/each}} |
kitagry
force-pushed
the
separate-change-kinds
branch
from
d6c280a
to
77498db
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #41 +/- ##
==========================================
+ Coverage 70.74% 74.37% +3.63%
==========================================
Files 7 7
Lines 728 804 +76
==========================================
+ Hits 515 598 +83
+ Misses 213 206 -7 ☔ View full report in Codecov by Sentry. |
|
I fixed! |
|
@kitagry Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
before
after