forked from getsentry/sentry-javascript
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Events can be added to buffer despite the session being expired #9
Labels
Comments
Click the checkbox below to generate a PR!
@hiroshinishio, You have 5 requests left in this cycle which refreshes on 2024-11-04 02:56:25+00:00. |
Sorry, we have an error. Please try again. Have feedback or need help? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Still investigating, but we are getting event buffer issues because expired sessions are not properly ending the session.handleException
is causing a possible infinite loop of sorts for expired sessions. it eventually ends up callingaddEvent()
which only checks if replay is paused or ended and not if session is valid. This causes a buildup in the buffer.e.g. user idles on the page and replay continues to try to flush after the session has ended. Session is not ending properly so buffer continues to grow in size and continues to flush.
This also causes a replay with canvas recordings because resets will cause a new web worker to initialize leading to browser crashes (Closes: getsentry#13743)
The text was updated successfully, but these errors were encountered: