-
-
Notifications
You must be signed in to change notification settings - Fork 189
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Global story controls not working for vue2 #266
Comments
I found that The But I prefer that see: https://histoire.dev/guide/vue2/controls.html#controls-panel |
@murongg that would be a feature request. What I meant is that story controls are simply not working (at all) for vue2. |
in plugin-vue2 RenderStory.ts line 114 const vnodes = props.variant.slots()?.[props.slotName]?.({
state: externalState,
}) ?? props.story.slots()?.[props.slotName]?.({
state: externalState,
}) here |
probably, because in Variant slots are |
yep, just changed it directly in the bundled dist and tried, I can see the global controls |
Describe the bug
Global controls within story #controls slot are not showing up.
same controls within variant #controls slot are working fine.
Reproduction
works
doesn't work
Based on docs: https://histoire.dev/guide/vue2/controls.html#controls-panel
System Info
Used Package Manager
npm
Validations
The text was updated successfully, but these errors were encountered: