Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A11y testing #85

Open
Akryum opened this issue May 9, 2022 · 8 comments
Open

A11y testing #85

Akryum opened this issue May 9, 2022 · 8 comments
Labels
enhancement New feature or request need spec Need Specs, UX or UI design...

Comments

@Akryum
Copy link
Member

Akryum commented May 9, 2022

We could leverage axe to get accessibility testing for stories.

@Akryum Akryum added enhancement New feature or request need spec Need Specs, UX or UI design... labels May 9, 2022
@alvarosabu
Copy link
Contributor

alvarosabu commented Jun 23, 2022

Hi, something similar to this addon https://storybook.js.org/addons/@storybook/addon-a11y?

I think it could be a really nice feature

@alvarosabu
Copy link
Contributor

@Akryum I will like to take this one, since I need it for my product.

Any wish list?

@Akryum
Copy link
Member Author

Akryum commented Aug 5, 2022

We can probably take inspiration from the ally one. Maybe a good first step would be to do some discovery about the things we might need to add to the Plugin API.

@alvarosabu
Copy link
Contributor

@Akryum Is it possible to create a new tab through the Plugin API? Also how to add the UI inside the tab (for example a list of the accessibility violations and links)

Screenshot 2022-08-09 at 15 24 46

@Akryum
Copy link
Member Author

Akryum commented Aug 9, 2022

That's thing that we would need to add to the Plugin API. Do you confirm you need the following for now?

  • Add a new tab
  • Render a component in it using the bundled Vue (integrate with the UI).

@alvarosabu
Copy link
Contributor

Yes, I think those two points will set the bases for plugins that need UI.

I wonder how we could access the current story document from the API ? With api.onPreviewStory?

I need to investigate if axe only works with a selector or if you can actually pass HTML, not sure

@Akryum
Copy link
Member Author

Akryum commented Aug 13, 2022

#240

@binaryfire
Copy link

This would be great. The lack of accessibility testing is the only thing stopping us migrating from Storybook to Histoire

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request need spec Need Specs, UX or UI design...
Projects
None yet
Development

No branches or pull requests

3 participants