Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(a11y): make font-size follow user brower settings #115

Merged
merged 1 commit into from
Jun 5, 2022

Conversation

kecrily
Copy link
Contributor

@kecrily kecrily commented Jun 5, 2022

Description

The browser's font resizing feature is one of the commonly used accessibility features. And it is disabled when the font size is set to px. The workaround is rem which uses root-based size units .

Additional context

The change before and after the modification when I resized the font to extra large.

Before

image

After

image

What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@netlify
Copy link

netlify bot commented Jun 5, 2022

Deploy Preview for histoire-examples-vue3 ready!

Name Link
🔨 Latest commit 87f4368
🔍 Latest deploy log https://app.netlify.com/sites/histoire-examples-vue3/deploys/629c5f8b3500f50008e0ad39
😎 Deploy Preview https://deploy-preview-115--histoire-examples-vue3.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Jun 5, 2022

Deploy Preview for histoire-site ready!

Name Link
🔨 Latest commit 87f4368
🔍 Latest deploy log https://app.netlify.com/sites/histoire-site/deploys/629c5f8b892d1d00083e6508
😎 Deploy Preview https://deploy-preview-115--histoire-site.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Jun 5, 2022

Deploy Preview for histoire-controls ready!

Name Link
🔨 Latest commit 87f4368
🔍 Latest deploy log https://app.netlify.com/sites/histoire-controls/deploys/629c5f8bc5e7850008101650
😎 Deploy Preview https://deploy-preview-115--histoire-controls.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@Akryum Akryum changed the title perf(a11y): make font-size follow user brower settings fix(a11y): make font-size follow user brower settings Jun 5, 2022
@Akryum Akryum merged commit e525332 into histoire-dev:main Jun 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants