-
-
Notifications
You must be signed in to change notification settings - Fork 189
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: do not add target blank to urls that start with # in markdown #235
fix: do not add target blank to urls that start with # in markdown #235
Conversation
✅ Deploy Preview for histoire-controls ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for histoire-site ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
2ad0d63
to
7e14068
Compare
✅ Deploy Preview for histoire-examples-vue3 ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
I could not run the code directly. I have tested it in our Project where I have found it with editing the code in node_modules directly. Here the issue that I have locally when I tried to run the code. Nodejs: 16.16.0 pnpm: 7.9.0
Do I need/should run all the task manual and just do not run the nuxt plugin for now as it looks like there is a problem. |
Could you rebase with main? |
7e14068
to
53885d2
Compare
After the rebase it works now. Should I add a new Story with only Markdown and a Link that links to a h1 on the page for example as a test? |
Sure! |
Added a small story and test. |
5810b22
to
8230222
Compare
Description
Currently it is not possible to add internal links starting with
#
as those gettarget=_blank
added.Additional context
#234
What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123
).