Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: config dev port (fix #317) #318

Merged
merged 4 commits into from
Oct 8, 2022
Merged

fix: config dev port (fix #317) #318

merged 4 commits into from
Oct 8, 2022

Conversation

hugoattal
Copy link
Collaborator

@hugoattal hugoattal commented Oct 7, 2022

Description

Dev port was always 6006 when not defined in the command line

Additional context

Example histoire config:

// vite.config.js
/// <reference types="histoire" />

import { defineConfig } from 'vite'

export default defineConfig({
  // ...
  histoire: {
    vite: {
      server: {
        port: 1980,
      },
    },
  },
})

What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

@hugoattal hugoattal self-assigned this Oct 7, 2022
@netlify
Copy link

netlify bot commented Oct 7, 2022

Deploy Preview for histoire-site ready!

Name Link
🔨 Latest commit 7d938fb
🔍 Latest deploy log https://app.netlify.com/sites/histoire-site/deploys/634050bbc1a4280009e2c29c
😎 Deploy Preview https://deploy-preview-318--histoire-site.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Oct 7, 2022

Deploy Preview for histoire-controls ready!

Name Link
🔨 Latest commit 7d938fb
🔍 Latest deploy log https://app.netlify.com/sites/histoire-controls/deploys/634050bb37dc630008c9bd0e
😎 Deploy Preview https://deploy-preview-318--histoire-controls.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Oct 7, 2022

Deploy Preview for histoire-examples-svelte3 ready!

Name Link
🔨 Latest commit 7d938fb
🔍 Latest deploy log https://app.netlify.com/sites/histoire-examples-svelte3/deploys/634050bb86a91c000852fbc0
😎 Deploy Preview https://deploy-preview-318--histoire-examples-svelte3.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Oct 7, 2022

Deploy Preview for histoire-examples-vue3 ready!

Name Link
🔨 Latest commit 7d938fb
🔍 Latest deploy log https://app.netlify.com/sites/histoire-examples-vue3/deploys/634050bc06479c000823a3a2
😎 Deploy Preview https://deploy-preview-318--histoire-examples-vue3.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

packages/histoire/src/node/server.ts Outdated Show resolved Hide resolved
packages/histoire/src/node/server.ts Outdated Show resolved Hide resolved
@hugoattal hugoattal requested a review from Akryum October 7, 2022 15:15
@Akryum
Copy link
Member

Akryum commented Oct 7, 2022

What happens when we don't configure the port in histoire config? Will it be the normal vite port? I'd prefer it to be 6006 by default unless explicitly set in histoireConfig.vite.server.port.

@hugoattal
Copy link
Collaborator Author

hugoattal commented Oct 7, 2022

Hum, I see... I updated the fix so that the port configured in the vite config file is overridden with 6006.

@Akryum Akryum merged commit 095d516 into main Oct 8, 2022
@Akryum Akryum deleted the fix-dev-port branch October 8, 2022 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants