Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Lock link color with tailwind class (fix #66) #67

Merged
merged 3 commits into from
Apr 19, 2022
Merged

fix: Lock link color with tailwind class (fix #66) #67

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
fba1409
fix: Lock link color with tailwind class
hugoattal Apr 13, 2022
ec44dae
typo
hugoattal Apr 13, 2022
190380e
fix cypress test
hugoattal Apr 13, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions examples/vue3/cypress/integration/search.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@ describe('Search', () => {
cy.visit('/')
// Click on backdrop
cy.get('[data-test-id="search-btn"]').click()
cy.get('[data-test-id="search-modal"]').should('be.visible')
cy.get('body').click(10, 10)
cy.get('[data-test-id="search-modal"]').should('not.be.visible')
// Use escape key
Expand Down
4 changes: 2 additions & 2 deletions packages/histoire/src/client/app/components/app/AppHeader.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ onKeyboardShortcut(['ctrl+shift+d', 'meta+shift+d'], (event) => {
<div class="htw-ml-auto htw-flex-none htw-flex">
<a
v-tooltip="makeTooltip('Search', ({ isMac }) => isMac ? 'meta+k' : 'ctrl+k')"
class="htw-p-2 sm:htw-p-1 hover:htw-text-primary-500 dark:hover:htw-text-primary-400 htw-cursor-pointer"
class="htw-p-2 sm:htw-p-1 hover:htw-text-primary-500 dark:hover:htw-text-primary-400 htw-cursor-pointer htw-text-gray-900 dark:htw-text-gray-100"
data-test-id="search-btn"
@click="$emit('search')"
>
Expand All @@ -51,7 +51,7 @@ onKeyboardShortcut(['ctrl+shift+d', 'meta+shift+d'], (event) => {

<a
v-tooltip="makeTooltip('Toggle dark mode', ({ isMac }) => isMac ? 'meta+shift+d' : 'ctrl+shift+d')"
class="htw-p-2 sm:htw-p-1 hover:htw-text-primary-500 dark:hover:htw-text-primary-400 htw-cursor-pointer"
class="htw-p-2 sm:htw-p-1 hover:htw-text-primary-500 dark:hover:htw-text-primary-400 htw-cursor-pointer htw-text-gray-900 dark:htw-text-gray-100"
@click="toggleDark()"
>
<Icon
Expand Down
2 changes: 1 addition & 1 deletion packages/histoire/src/client/app/components/base/BaseListItemLink.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ export default defineComponent({
>
<a
:href="href"
class="htw-flex htw-items-center htw-gap-2"
class="htw-flex htw-items-center htw-gap-2 htw-text-gray-900 dark:htw-text-gray-100"
:class="[
$attrs.class,
(isActive != null ? isActive : linkIsActive)
Expand Down
2 changes: 1 addition & 1 deletion packages/histoire/src/client/app/components/base/BaseTab.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ export default defineComponent({
<a
v-bind="$attrs"
:href="href"
class="htw-px-4 htw-h-full htw-inline-flex htw-items-center hover:htw-bg-primary-50 dark:hover:htw-bg-primary-900 htw-relative"
class="htw-px-4 htw-h-full htw-inline-flex htw-items-center hover:htw-bg-primary-50 dark:hover:htw-bg-primary-900 htw-relative htw-text-gray-900 dark:htw-text-gray-100"
:class="{
'htw-text-primary-500 dark:htw-text-primary-400': matched != null ? matched : (exact && isExactActive) || (!exact && isActive),
}"
Expand Down
2 changes: 1 addition & 1 deletion packages/histoire/src/client/app/components/story/toolbar/StoryVariantNewTab.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ const sandboxUrl = computed(() => {
v-tooltip="'Open variant in new tab'"
:href="sandboxUrl"
target="_blank"
class="htw-flex htw-items-center htw-gap-1 htw-h-full htw-px-2 hover:htw-text-primary-500 htw-opacity-50 hover:htw-opacity-100"
class="htw-flex htw-items-center htw-gap-1 htw-h-full htw-px-2 hover:htw-text-primary-500 htw-opacity-50 hover:htw-opacity-100 dark:hover:htw-text-primary-400 htw-text-gray-900 dark:htw-text-gray-100"
>
<Icon
icon="carbon:launch"
Expand Down