Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add CSS layer to bypass base rules #747

Closed
wants to merge 3 commits into from
Closed

Conversation

hugoattal
Copy link
Collaborator

@hugoattal hugoattal commented Jul 28, 2024

Description

I added a CSS layer to make it easier to overwrite the base CSS.

Additional context

Ref:

Note, I changed the layer @base to @histoire: it seems that this specific name for a layer does weird stuff with PostCSS.

⚠️ I have no idea what is the problem with the workflow... I even revert the pnpm-lock file (which is a bit outdate, we're at version 9 of pnpm 😕)


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

@hugoattal hugoattal self-assigned this Jul 28, 2024
Copy link

codesandbox bot commented Jul 28, 2024

Review or Edit in CodeSandbox

Open the branch in Web EditorVS CodeInsiders

Open Preview

Copy link

stackblitz bot commented Jul 28, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Copy link

netlify bot commented Jul 28, 2024

Deploy Preview for histoire-examples-vue3 ready!

Name Link
🔨 Latest commit 2d463c8
🔍 Latest deploy log https://app.netlify.com/sites/histoire-examples-vue3/deploys/66a69f36c383ca0008d0a3e6
😎 Deploy Preview https://deploy-preview-747--histoire-examples-vue3.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Jul 28, 2024

Deploy Preview for histoire-controls ready!

Name Link
🔨 Latest commit 2d463c8
🔍 Latest deploy log https://app.netlify.com/sites/histoire-controls/deploys/66a69f36321f490009c53052
😎 Deploy Preview https://deploy-preview-747--histoire-controls.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Jul 28, 2024

Deploy Preview for histoire-site ready!

Name Link
🔨 Latest commit 2d463c8
🔍 Latest deploy log https://app.netlify.com/sites/histoire-site/deploys/66a69f363ed7c30008a3e242
😎 Deploy Preview https://deploy-preview-747--histoire-site.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Jul 28, 2024

Deploy Preview for histoire-examples-svelte3 ready!

Name Link
🔨 Latest commit 2d463c8
🔍 Latest deploy log https://app.netlify.com/sites/histoire-examples-svelte3/deploys/66a69f36edf8780008ce42c6
😎 Deploy Preview https://deploy-preview-747--histoire-examples-svelte3.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@hugoattal hugoattal changed the title fix: leaking css (fix #339) fix: add CSS layer to bypass base rules Jul 28, 2024
@hugoattal hugoattal closed this Jul 28, 2024
@hugoattal hugoattal deleted the fix/isolated-style branch July 30, 2024 00:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant