Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor Resolver._get_install_requirements() #1

Closed
wants to merge 1 commit into from
Closed

Refactor Resolver._get_install_requirements() #1

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 5 additions & 10 deletions piptools/resolver.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -609,14 +609,8 @@ def resolve(self, max_rounds: int = 10) -> Set[InstallRequirement]:
resolver_result = resolver._result
assert isinstance(resolver_result, Result)

# Get reverse requirements from the resolver result graph.
reverse_dependencies = self._get_reverse_dependencies(resolver_result)

# Prepare set of install requirements from resolver result.
result_ireqs = self._get_install_requirements(
resolver_result=resolver_result,
reverse_dependencies=reverse_dependencies,
)
result_ireqs = self._get_install_requirements(resolver_result=resolver_result)

# Filter out unsafe requirements.
if not self.allow_unsafe:
Expand Down Expand Up @@ -676,13 +670,14 @@ def _do_resolve(
return True

def _get_install_requirements(
self,
resolver_result: Result,
reverse_dependencies: Dict[str, Set[str]],
self, resolver_result: Result
) -> Set[InstallRequirement]:
"""Return a set of install requirements from resolver results."""
result_ireqs: Dict[str, InstallRequirement] = {}

# Get reverse requirements from the resolver result graph.
reverse_dependencies = self._get_reverse_dependencies(resolver_result)

# Transform candidates to install requirements
resolved_candidates = tuple(resolver_result.mapping.values())
for candidate in resolved_candidates:
Expand Down