Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notes from pyctdev review #76

Open
tonyfast opened this issue Nov 17, 2020 · 3 comments
Open

Notes from pyctdev review #76

tonyfast opened this issue Nov 17, 2020 · 3 comments

Comments

@tonyfast
Copy link

with @kcpevey

  • task_ecosystem_setup pip upgrades distribution tools.
  • task_env_create does nothin in pip, but is overriden in conda
  • should use LongRunning instead of CmdAction when possible
  • task_dev_install, _pip_... builds a pip command to update the environment.
  • consider using flakehell instead of flake8
  • move linting after testing
  • coveralls coverage task.

suggestions

  • squash pip and conda setup into one smart function.
  • squash environment variable setup into tasks.
@kcpevey
Copy link

kcpevey commented Nov 17, 2020

  • move from cli params to env vars

@tonyfast
Copy link
Author

  • add a smoke test that fails quicker than the full test suite.

@kcpevey
Copy link

kcpevey commented Nov 20, 2020

we can run the smoke test concurrent with the full test suite in gh actions so it will fail faster without impacting the full run time.

And it may also be possible to stop all tests if the smoke test fails even if they've already started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants