Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes addressed in this PR:
IntakeSource
andIntakeSQLSource
separatelyFileSource
to a new fileJSONSource
JoinedSource
Source.from_spec
when loading from source instate.sources
Bug fixes:
JSONSource._resolve_template_vars()
: converttemplate
to string to make surere.findall(template)
work properly. Currently, a local file path will be read as apathlib.PosixPath
object: https:/holoviz/lumen/blob/master/lumen/sources/base.py#L528