Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add TYPE_CHECKING to coverage excludes #47668

Merged
merged 1 commit into from
Mar 9, 2021
Merged

Add TYPE_CHECKING to coverage excludes #47668

merged 1 commit into from
Mar 9, 2021

Conversation

cdce8p
Copy link
Member

@cdce8p cdce8p commented Mar 9, 2021

Proposed change

Add if TYPE_CHECKING: to coverage exclude_lines. The TYPE_CHECKING block will never be executed by pytest.
nedbat/coveragepy#831

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

@probot-home-assistant probot-home-assistant bot added code-quality small-pr PRs with less than 30 lines. labels Mar 9, 2021
MartinHjelmare
MartinHjelmare approved these changes Mar 9, 2021
View reviewed changes
Copy link
Member

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@cdce8p cdce8p merged commit 0c61cb5 into home-assistant:dev Mar 9, 2021
@cdce8p cdce8p deleted the coverage-type_checking branch March 9, 2021 13:57
@github-actions github-actions bot locked and limited conversation to collaborators Mar 10, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@MartinHjelmare MartinHjelmare MartinHjelmare approved these changes

Assignees
No one assigned
Labels
cla-signed code-quality small-pr PRs with less than 30 lines.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cdce8p @MartinHjelmare @homeassistant