Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Start ServiceBrowser as soon as possible in zeroconf #50784

Merged
merged 11 commits into from
May 18, 2021

Conversation

bdraco
Copy link
Member

@bdraco bdraco commented May 17, 2021

Proposed change

Ensures the cache is being populated as soon as possible so we don't miss other Home Assistant instances in the short window we check for conflicting names.

May help with #50695 but either way this should be more robust.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@bdraco
Copy link
Member Author

bdraco commented May 17, 2021

We also need to make sure we add _homeassistant._tcp.local. to the types to get all the instances on the network in time before we register

@bdraco bdraco removed the waiting-for-upstream We're waiting for a change upstream label May 17, 2021
@bdraco bdraco marked this pull request as ready for review May 18, 2021 02:12
@balloob balloob merged commit 3cc3cac into home-assistant:dev May 18, 2021
@bdraco bdraco mentioned this pull request May 19, 2021
21 tasks
@github-actions github-actions bot locked and limited conversation to collaborators May 20, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants