feat: EMAThroughput sampler #58
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kentquirk
added
type: enhancement
version: bump minor
kentquirk
force-pushed
the
kent.emathroughput
branch
from
3fb72a1
to
c143ded
Compare
| var _ Sampler = (*EMAThroughput)(nil) | ||
|
|
||
| func (e *EMAThroughput) Start() error { | ||
| // apply defaults |
There was a problem hiding this comment.
Could be nice to have these defaults defined as constants where possible.
There was a problem hiding this comment.
They're configuration default values; the only use of them is here. To me it seems counterproductive to invent a new set of names for the constants and move them to a block located elsewhere. I feel like that's why a Start() function exists.
TylerHelmuth
approved these changes
Mar 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a new sampler type, an EMAThroughput sampler.
The EMASampleRate sampler requires specifying a desired sample rate. But more often, what someone would like to do is specify a given throughput. The WindowedThroughput sampler does that, but does so at the cost of maintaining a buffer of N previous sample rates, each of which is of equal weight.
The EMAThroughput sampler maintains a diminishing moving average of samples over time; older data is of less weight than current data. It also doesn't need to maintain any extra buffers.
Fixes #51.