-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Investigate self-signed HTTPS #78
Labels
Comments
I'd support adding an additional configuration option to allow self-signed certs. |
I skipped checking the certificate where the code creates http.client and it works fine now
|
I created a patch file for the issue. The approach is same with @ispy1. :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
It would seem (according to an email report) that upstream self-signed certificates do not work, this needs to be checked.
Then, we need to figure out whether self-signed or invalid certificates should be allowed by default. I don’t see a security risk from doing that but it might make debugging harder or more confusing because we would bypass those issues.
I’m thinking the best option is to add it behind a flag.
The text was updated successfully, but these errors were encountered: